Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lookup: skip some permanently failing modules #880

Merged
merged 1 commit into from
Nov 29, 2021
Merged

lookup: skip some permanently failing modules #880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 13 additions & 6 deletions lib/lookup.json
View file
Open in desktop
Expand Up @@ -2,7 +2,8 @@
"@hapi/hapi": {
"prefix": "v",
"maintainers": ["devinivy", "DavidTPate", "AdriVanHoudt"],
"skip": ["darwin", "aix", "debian"]
"skip": ["darwin", "aix", "debian", ">=17"],
"comment": "Verbatim DNS output"
},
"@hapi/shot": {
"maintainers": "cjihrig",
Expand Down Expand Up @@ -89,6 +90,7 @@
"cheerio": {
"skip": ["aix", "win32"],
"head": true,
"useGitClone": true,
"maintainers": ["matthewmueller", "jugglinmike"]
},
"clinic": {
Expand All @@ -99,7 +101,7 @@
},
"coffeescript": {
"maintainers": ["jashkenas", "GeoffreyBooth"],
"skip": "rhel"
"skip": ["rhel", "aix"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn’t aware of this . . . there’s not really any reason I can think of that CoffeeScript should fail in any environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIX: https://ci.nodejs.org/job/citgm-smoker/nodes=aix72-ppc64/2790/testReport/junit/(root)/citgm/coffeescript_v2_6_1/

 npm ERR! code 1
 npm ERR! path /home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/coffeescript/node_modules/puppeteer
 npm ERR! command failed
 npm ERR! command sh -c node install.js
 npm ERR! /home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/coffeescript/node_modules/puppeteer/lib/cjs/puppeteer/common/assert.js:26
 npm ERR!         throw new Error(message);
 npm ERR!               ^
 npm ERR! 
 npm ERR! Error: Unsupported platform: aix
 npm ERR!     at Object.assert (/home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/coffeescript/node_modules/puppeteer/lib/cjs/puppeteer/common/assert.js:26:15)
 npm ERR!     at BrowserFetcher.setPlatform (/home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/coffeescript/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:180:25)
 npm ERR!     at new BrowserFetcher (/home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/coffeescript/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:164:14)
 npm ERR!     at PuppeteerNode.createBrowserFetcher (/home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/coffeescript/node_modules/puppeteer/lib/cjs/puppeteer/node/Puppeteer.js:185:16)
 npm ERR!     at downloadBrowser (/home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/coffeescript/node_modules/puppeteer/lib/cjs/puppeteer/node/install.js:42:46)
 npm ERR!     at download (/home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/coffeescript/node_modules/puppeteer/install.js:86:3)
 npm ERR! 
 npm ERR! Node.js v18.0.0-pre
 npm ERR! A complete log of this run can be found in:
 npm ERR!     /home/iojs/tmp/citgm_tmp/28cfdfc7-146e-4343-9f50-352435316c6c/home/.npm/_logs/2021-11-06T19_04_46_623Z-debug.log

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the tests, that makes sense. If I wanted to get the tests running in AIX, say by disabling Puppeteer in AIX, is there some way I could launch an AIX environment to test that my changes work?

},
"commander": {
"prefix": "v",
Expand Down Expand Up @@ -171,7 +173,8 @@
"express-session": {
"prefix": "v",
"maintainers": "dougwilson",
"skip": "win32"
"skip": ">=16",
"comment": "https://github.com/expressjs/session/pull/844"
},
"fastify": {
targos marked this conversation as resolved.
Show resolved Hide resolved
"maintainers": ["mcollina", "delvedor"],
Expand Down Expand Up @@ -361,7 +364,8 @@
"path-to-regexp": {
"prefix": "v",
"maintainers": "blakeembrey",
"skip": ["aix"]
"skip": ["aix", ">=17"],
"comment": "OpenSSL 3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the tests appear to pass with --openssl-legacy-provider, see https://ci.nodejs.org/job/citgm-smoker-nobuild/1111/ which uses NODE_OPTIONS which we could set via envVar.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I guess that wouldn't work for older versions of Node.js 😞.

},
"pino": {
"prefix": "v",
Expand Down Expand Up @@ -459,7 +463,9 @@
},
"socket.io": {
"maintainers": "rauchg",
"head": true
"head": true,
"skip": ">=17",
"comment": "WS is not compatible"
},
"spawn-wrap": {
"prefix": "v",
Expand Down Expand Up @@ -533,7 +539,8 @@
"prefix": "v",
"flaky": ["ppc", "darwin"],
"maintainers": "mishoo",
"skip": "12"
"skip": ["12", true],
"comment": "Tests timeout"
},
"underscore": {
"flaky": ["aix", "s390"],
Expand Down