chore: enable node 12 and win32 for serialport #720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serialport
now supports node 12. It has always supported windows32 (and it tested against it) so I’ve brought that back. I couldn’t find issues that explained why it was removed. The commit suggested that maybe it was flakey? If so I’d like to know more as we don’t see that in our tests.Closes: serialport/node-serialport#1742
Checklist
npm test
passeshere