Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable node 12 and win32 for serialport #720

Merged
merged 1 commit into from May 1, 2019

Conversation

reconbot
Copy link
Contributor

serialport now supports node 12. It has always supported windows32 (and it tested against it) so I’ve brought that back. I couldn’t find issues that explained why it was removed. The commit suggested that maybe it was flakey? If so I’d like to know more as we don’t see that in our tests.

Closes: serialport/node-serialport#1742

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-io
Copy link

codecov-io commented Apr 27, 2019

Codecov Report

Merging #720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          27       27           
  Lines         876      876           
=======================================
  Hits          835      835           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65183f...2f362ab. Read the comment docs.

@targos
Copy link
Member

targos commented Apr 27, 2019

@reconbot
Copy link
Contributor Author

I don't really understand some of those errors.. I'll put back the ignore win32 for now and see what happens.

@BridgeAR
Copy link
Member

On Windows 2008:

MSBUILD : error MSB3428: Could not load the Visual C++ component "VCBuild.exe". To fix this, 1) install the .NET Framework 2.0 SDK, 2) install Microsoft Visual Studio 2005 or 3) add the location of the component to the system path if it is installed elsewhere.  [C:\workspace\citgm-smoker-nobuild\workspacecitgm-smoker-nobuild\citgm_tmp\8e3d1001-8e19-4342-b349-4f54a3a077c3\serialport\packages\bindings\build\binding.sln]
 lerna ERR! npm install stderr:
 Warning: unrecognized setting VCCLCompilerTool/MultiProcessorCompilation
 Warning: unrecognized setting VCCLCompilerTool/MultiProcessorCompilation
 gyp ERR! build error 
 gyp ERR! stack Error: `C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe` failed with exit code: 1

@reconbot
Copy link
Contributor Author

I can't support windows 2008, it's build chain is super outdated and I don't have any test machines.

@targos targos merged commit 75bac16 into nodejs:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Node 12/master
4 participants