lookup: unflake node-report on Windows #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that node-report is currently broken on Node.js 11 (nodejs/node#24861 (comment)) and currently is one of several addons that require a |
and I should add I'm not marking it flaky on 11 as it sounds like the correct thing to do is to fix the regression in Node.js 11. |
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 26 26
Lines 824 824
=======================================
Hits 778 778
Misses 46 46Continue to review full report at Codecov.
|
node-report@2.2.2 fixes compilation on Windows. PR-URL: nodejs#675 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau
force-pushed
the
unflake-nodereport-win
branch
from
77883fb
to
185f423
Compare
BridgeAR
approved these changes
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-report@2.2.2 fixes compilation on Windows.
Checklist
here