jenkins: pack embedtest.exe for Windows builds

[vmoroz]

CI runs for PR nodejs/node#52646 fail because the embedtest.exe is not packaged along with other binary files and it cannot be found by the test being enabled.

This PR changes Jenkins Windows scripts to treat embedtest.exe the same way as cctest.exe.
The only difference is that we check that embedtest.exe file exists.
It must unblock the PR nodejs/node#52646.

[richardlau]

cc @StefanStojanovic

[StefanStojanovic]

The changes look reasonable and good. Just to check, was this tested through CI? Eg. with a copy of the Windows job using this branch instead of the main one?

[richardlau]

Just to check, was this tested through CI? Eg. with a copy of the Windows job using this branch instead of the main one?

I don't believe so.

[vmoroz]

The changes look reasonable and good. Just to check, was this tested through CI? Eg. with a copy of the Windows job using this branch instead of the main one?

No, I did not test it this way. How can I do it?

[StefanStojanovic]

No, I did not test it this way. How can I do it?

You'd need a higher access level to Jenkins to create a job copy and point it to your branch. I will do that for you. and send the run here.

[StefanStojanovic]

Here is the CI run (run 1 failure is something unrelated to this). I used this branch for jobs and ran the branch from nodejs/node#52646 through CI. Everything seems to be in order.

[mhdawson]

LGTM

[mhdawson]

Based on what @StefanStojanovic mentioned in terms of testing looks like this is ready to land, landing.

[vmoroz]

Here is the CI run (run 1 failure is something unrelated to this). I used this branch for jobs and ran the branch from nodejs/node#52646 through CI. Everything seems to be in order.

Thank you, @StefanStojanovic , for verifying it!