Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Brave fingerprinting #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nextend
Copy link

@nextend nextend commented Jun 28, 2023

#229

Brave browser also have fingerprinting protection for canvas. But it seems like Brave only shifts colors a little bit, so Pica is unable to generate the image while the output image could be pretty good.

[12, 23, 34, 255, 45, 56, 67, 255] <- Original
[13, 22, 34, 255, 45, 57, 66, 255] <- Brave
[86, 206, 251, 191, 18, 101, 167, 28] <- Firefox

Each color part can have +-5 difference to the original value which works good with Brave browser and still able to detect Firefox fingerprinting protection.

@annahassel
Copy link

@puzrin Hello, what do you think about this fix? Is it possible to fix pica for Brave?

@puzrin
Copy link
Member

puzrin commented Dec 8, 2023

I don't like idea to generate "something" instead of predictable result.

@annahassel
Copy link

I don't like idea to generate "something" instead of predictable result.

Thank you for the answer!

@mylastore
Copy link

mylastore commented May 22, 2024

How to throw an error when fingerprinting is detected?
We want to display an error to let the user know why the image did not succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants