Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add equals sign to list of unsafe values for plain styling #519

Merged
merged 9 commits into from Oct 17, 2019
Merged

Add equals sign to list of unsafe values for plain styling #519

merged 9 commits into from Oct 17, 2019

Commits on Oct 11, 2019

  1. Add equals sign to list of values not considered safe for plain styling 

    According to this post and my use case, the strings with equals sign needs to be quoted:
https://stackoverflow.com/questions/19109912/do-i-need-quotes-for-strings-in-yaml
Use quotes if your value includes special characters, (e.g. :, {, }, [, ], ,, &, *, #, ?, |, -, <, >, =, !, %, @, \).
    @murtazajafferji
    murtazajafferji committed Oct 11, 2019
    Copy the full SHA
    7c21051 View commit details
    Browse the repository at this point in the history

  2. Remove extra character

    @murtazajafferji
    murtazajafferji committed Oct 11, 2019
    Copy the full SHA
    8b7ff6f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Add test to ensure quotes around lines with equals sign are not stripped

    @murtazajafferji
    murtazajafferji committed Oct 15, 2019
    Copy the full SHA
    0ec88e3 View commit details
    Browse the repository at this point in the history

  2. Fix test by adding newline

    @murtazajafferji
    murtazajafferji committed Oct 15, 2019
    Copy the full SHA
    1540135 View commit details
    Browse the repository at this point in the history

  3. Update test name and contents to be more clear about intention

    @murtazajafferji
    murtazajafferji committed Oct 15, 2019
    Copy the full SHA
    fad86cd View commit details
    Browse the repository at this point in the history

  4. Fix test by adding newline

    @murtazajafferji
    murtazajafferji committed Oct 15, 2019
    Copy the full SHA
    2245cd4 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Move back single quote

    @murtazajafferji
    murtazajafferji committed Oct 17, 2019
    Copy the full SHA
    40707dd View commit details
    Browse the repository at this point in the history

  2. Move back double quote

    @murtazajafferji
    murtazajafferji committed Oct 17, 2019
    Copy the full SHA
    62a550c View commit details
    Browse the repository at this point in the history

  3. Remove trailing space

    @murtazajafferji
    murtazajafferji committed Oct 17, 2019
    Copy the full SHA
    9566bc9 View commit details
    Browse the repository at this point in the history