Fix issue #526: wrong quote position writing condensed flow (#527)

Fix issue #526: wrong quote position writing condensed flow
nodeca · Nov 15, 2019 · d6983dd · d6983dd
2 parents e569cc7 + 93fbf7d
commit d6983dd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/js-yaml/dumper.js b/lib/js-yaml/dumper.js
@@ -569,10 +569,12 @@ function writeFlowMapping(state, level, object) {
       pairBuffer;
 
   for (index = 0, length = objectKeyList.length; index < length; index += 1) {
-    pairBuffer = state.condenseFlow ? '"' : '';
 
+    pairBuffer = '';
     if (index !== 0) pairBuffer += ', ';
 
+    if (state.condenseFlow) pairBuffer += '"';
+
     objectKey = objectKeyList[index];
     objectValue = object[objectKey];
 

diff --git a/test/issues/0346.js b/test/issues/0346.js
@@ -15,11 +15,11 @@ test('should not emit spaces in arrays in flow mode between entries using conden
 });
 
 test('should not emit spaces between key: value and quote keys using condenseFlow: true', function () {
-  var object = { a: { b: 'c' } };
+  var object = { a: { b: 'c', d: 'e' } };
   var objectDump = yaml.dump(object, { flowLevel: 0, indent: 0, condenseFlow: true });
   assert.equal(
     objectDump,
-    '{"a":{"b":c}}\n'
+    '{"a":{"b":c, "d":e}}\n'
   );
   assert.deepEqual(yaml.load(objectDump), object);
 });