Update README to reflect valid values for validateInResponseTo #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
requested changes
Aug 10, 2023
| @@ -176,7 +176,7 @@ Please see the [type specification](https://github.com/node-saml/node-saml/blob/ | |||
|
|
|||
| ##### **InResponseTo Validation** | |||
|
|
|||
| - `validateInResponseTo`: if truthy, then InResponseTo will be validated from incoming SAML responses | |||
| - `validateInResponseTo`: if set to `always` or `ifPresent`, then InResponseTo will be validated from incoming SAML responses. The default setting is `never`, so this setting needs to be set if you want to validate incoming SAML responses. | |||
There was a problem hiding this comment.
Let's change the default to "always" for master and have another PR that uses this verbiage against the 4.x branch.
There was a problem hiding this comment.
There is no 4.x branch in this repo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #875 +/- ##
=======================================
Coverage 64.42% 64.42%
=======================================
Files 4 4
Lines 149 149
Branches 37 37
=======================================
Hits 96 96
Misses 30 30
Partials 23 23 ☔ View full report in Codecov by Sentry. |
cjbarth
added
pending-refinement
documentation
|
This PR is stale because is has been open for 90 days with no activity. |
|
Closed by #886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The updated documentation reflects the changes I proposed in my issue: #874
The documentation is outdated and after node-saml v4, just passing a truthy value does not affect the validateInResponseTo setting. node-saml expects a valid value, which my other PR enforces: node-saml/node-saml#314