Revised AbstractStrategy for authenticate method to match PassportStrategy expectation #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
requested changes
May 29, 2023
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
=======================================
Coverage 65.10% 65.10%
=======================================
Files 4 4
Lines 149 149
Branches 37 37
=======================================
Hits 97 97
Misses 29 29
Partials 23 23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Removed package updates and rebased against current master |
cjbarth
approved these changes
May 29, 2023
cjbarth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised AbstractStrategy for authenticate method to match PassportStrategy expectation
Description
The previous implementation was using the RequestWithUser internal type that contradict the base PassportStrategy authenticate given that user property SHOULD NOT be required for this process.
This causes a typings issue with the base passport which overrides the express Request interface to have a user property that is of type User | undefined;
Checklist: