Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure optional logger function to log SAML operations #854

Closed
wants to merge 2 commits into from

Conversation

RajuTanchak
Copy link

@RajuTanchak RajuTanchak commented Apr 5, 2023

Description

Extended StrategyOptions to define optional logger function to log SAML request/response with respect to node-saml library issue.

Checklist:

@cjbarth
Copy link
Collaborator

cjbarth commented Apr 11, 2023

What kind of information are you looking for when logging? Our logging of problems has gotten pretty good since the related issue was opened.

@RajuTanchak
Copy link
Author

What kind of information are you looking for when logging? Our logging of problems has gotten pretty good since the related issue was opened.

Need to supply log function in StrategyOptions with respect to changes done on this PR.

@cjbarth
Copy link
Collaborator

cjbarth commented May 29, 2023

It seems that this isn't going to more forward. It can be reopened if it does.

@cjbarth cjbarth closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants