Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old callback functions, tests use async/await #545

Merged
merged 3 commits into from Feb 23, 2021
Merged

remove old callback functions, tests use async/await #545

merged 3 commits into from Feb 23, 2021

Conversation

gugu
Copy link
Contributor

@gugu gugu commented Feb 23, 2021

No description provided.

@gugu gugu requested a review from cjbarth February 23, 2021 11:48
cjbarth
cjbarth requested changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@cjbarth cjbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, pretty good. There was just one spelling mistake I found and a few places where it seems we are using the wrong assert.

test/tests.spec.ts Outdated Show resolved Hide resolved
test/tests.spec.ts Outdated Show resolved Hide resolved
test/tests.spec.ts Outdated Show resolved Hide resolved
test/tests.spec.ts Outdated Show resolved Hide resolved
test/tests.spec.ts Show resolved Hide resolved
test/tests.spec.ts Outdated Show resolved Hide resolved
@cjbarth
Copy link
Collaborator

cjbarth commented Feb 23, 2021

Don't forget to squash merge.

@gugu gugu merged commit 8a1a377 into master Feb 23, 2021
@gugu gugu deleted the tests-async-await branch February 23, 2021 17:30
@cjbarth cjbarth mentioned this pull request May 10, 2021
Merged
@cjbarth cjbarth added the chore Refactoring, etc. to keep code-rot in check. label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjbarth cjbarth cjbarth approved these changes

Assignees
No one assigned
Labels
chore Refactoring, etc. to keep code-rot in check.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gugu @cjbarth