async / await in cache interface #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
requested changes
Feb 9, 2021
cjbarth
approved these changes
Feb 10, 2021
|
Please use a "Squash and merge" when merging to keep the git history cleaner. |
Merged
gugu
pushed a commit
that referenced
this pull request
Jun 15, 2021
Cache Provider interface has changed in #532 . This updates the readme for the new interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the cache interface is a very important part of this module because the default one is not usable in the production environment.
For compatibility reasons the interface was kept callback-based, despite the module itself uses async/await under the hood. For v3 I propose this breaking change to simplify our and users' code