Correctly reset Sinon fake timers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This problem will be easier to find once this is released. |
cjbarth
force-pushed
the
fix-fake-timers
branch
from
2b03751
to
31dcd1c
Compare
|
The entire method of this PR was changed because there is now an update to the Sinon library that will catch if you're using the fake timers incorrectly. Thus, the changes were paired back to be only what was needed. The code is still a little complex, but that can be saved for a proper test refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some testing of the tests, it was found that some tests randomly failed. Diagnosis revealed it was because we were overwriting the
fakeClockvariable at times and therefore were not correctlyrestoreing the built-in timers, causing problems for following tests. This will fix that.The pattern followed is to allow a
describeblocksbeforeEachandafterEachto set up and tear down fake timers if, and only if, each childitblock needs the same fake timer. In every other case atry...finallyblock was used in theitblock to build a local fake timer and tear it down, no matter what failures the test might experience.