Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate calls to the cache provider #4

Merged
merged 1 commit into from May 21, 2021

Conversation

jamiees2
Copy link
Contributor

Description

Replay of node-saml/passport-saml#596 onto this repo:

When validateInResponseTo isn't set to true, we end up setting it to false here: https://github.com/node-saml/passport-saml/blob/13c7216644ba055217fc97b41df63301be982137/src/node-saml/saml.ts#L155

This value was then checked if it's not null here, which is always true. The intention was likely to have this check check if the value was true, like everywhere else this value is used. This changes the gate to just check if the value is true.

This is a small enough change so I won't default to writing a test for this edge behavior - an extra delete call to the cache provider isn't a big deal, but I found this when debugging our custom cache provider.

Checklist:

  • Issue Addressed: [x]
  • Link to SAML spec: [ ]
  • Tests included? [ ]
  • Documentation updated? [ ]

@cjbarth cjbarth merged commit 596ecdb into node-saml:master May 21, 2021
@jamiees2 jamiees2 deleted the patch-1 branch May 21, 2021 21:25
@cjbarth cjbarth added the bug Something isn't working label Nov 17, 2021
@cjbarth cjbarth changed the title Update saml.ts Remove duplicate calls to the cache provider Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants