Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom highWaterMark #450

Merged
merged 2 commits into from
May 21, 2023
Merged

feat: support custom highWaterMark #450

merged 2 commits into from
May 21, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 21, 2023

closes #435

@fengmk2 fengmk2 added the enhancement New feature or request label May 21, 2023
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #450 (eae98ec) into master (d4e5f39) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files           8        8           
  Lines        1243     1246    +3     
  Branches      240      241    +1     
=======================================
+ Hits         1237     1240    +3     
  Misses          6        6           
Impacted Files Coverage Δ
src/HttpClient.ts 99.51% <100.00%> (+<0.01%) ⬆️
src/Request.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

assert.equal(bytes2.length, size);
const use2 = Date.now() - start;
console.log('highWaterMark 128KB use %dms', use2);
// assert(use2 < use1);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是大概率事件不是100%

@fengmk2 fengmk2 merged commit a324eeb into master May 21, 2023
22 checks passed
@fengmk2 fengmk2 deleted the support-highWaterMark branch May 21, 2023 05:50
fengmk2 pushed a commit that referenced this pull request May 21, 2023
[skip ci]

## [3.16.0](v3.15.0...v3.16.0) (2023-05-21)

### Features

* support custom highWaterMark ([#450](#450)) ([a324eeb](a324eeb))
@github-actions
Copy link

🎉 This PR is included in version 3.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change the default highWaterMark on http request
1 participant