Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: keep reference buffer alive longer #55

Merged
merged 3 commits into from
Mar 17, 2021

Commits on Feb 12, 2021

  1. src: keep reference buffer alive longer

    Keep a buffer written by WritePointer alive
    until the finalizers for the buffer to which
    the pointer has been run have been executed:
    
    Refs: node-ffi-napi#54
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    mhdawson committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    c882e1c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. limit change to writePointer

    Update to avoid changing behaviour for
    _writePointer and limit change to writePointer
    where objects were already being associated
    with the buffer.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    mhdawson committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    4cf8eed View commit details
    Browse the repository at this point in the history
  2. remove _attach call in writePointer

    remove _attach call in writePointer as
    it is no longer needed since a stronger
    version is done in the native code
    when true is passed as the fourth parameter
    mhdawson committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    63cd269 View commit details
    Browse the repository at this point in the history