Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify README pointer to v2 #1788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

skagedal
Copy link

@skagedal skagedal commented Nov 11, 2023

Purpose

I am new to node-fetch, and the first thing I saw on the npm.js site was this pointer. It sounds a little bit like it's saying that you're looking at an old version of the README (v1), and should be looking at v2. Here is a suggestion for how to make the intention a bit clearer.

Changes

Additional information


  • I updated readme
  • I added unit test(s)

  • fix #000

Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants