[#1576] Fixes unexpected premature close on chunked responses #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love to test out this PR, we suffer quite a lot from a premature close issue in node-fetch in the storybook pipeline:
Not sure if it is related, but we have no clue how to fix it. |
|
This PR should be merged. We suffer the same problem, and this patch fixed it. It must be released in npm (3.x.x and 2.x.x), thanks! |
|
@LinusU would you maybe be so kind to assign other reviewers in case you don't have the time right now? |
|
+1 |
|
bump...kinda a big deal, this problem |
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1576 (unexpected premature close errors on chunked responses)
Changes
It corrects a false assumption about split of the 'LAST CHUNK' marker between the previous and current buffer. The new solution concatenates last bytes of the previous buffer with all bytes from the current buffer (if that holds less then 5 bytes) and does the check on that.
Additional information
Premature closeerrors unexpectedly but very reliably in specific circumstances #1576