Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop support for Node 12 #1483

Merged
merged 3 commits into from Jan 27, 2022

Conversation

jimmywarting
Copy link
Collaborator

Purpose

Have created a beta branch and tough to start working on it already

Changes

  • update ci workflow to only test v14.17 and above
  • created a v4 limits + upgrade doc

Additional information

The documentation in v4 upgrade is changes to expect to come, they are not yet fixed...


  • I updated readme
  • I created a upgrade guide
  • I change CI workflow to only test node 14.17+
  • start working on this.

@jimmywarting
Copy link
Collaborator Author

Hoping i'm doing this correctly now @gr2m when starting of with the v4 milestone / beta

@gr2m
Copy link
Collaborator

gr2m commented Jan 25, 2022

Hoping i'm doing this correctly now @gr2m when starting of with the v4 milestone / beta

I'd add a "BREAKING CHANGE: drop support for Node 12" or similar to the commit message body when you squash & merge, otherwise this looks good :)

@jimmywarting jimmywarting changed the title chore: change supported version range BREAKING CHANGE: drop support for Node 12 Jan 26, 2022
@jimmywarting
Copy link
Collaborator Author

seem like Semantic Pull Request linter didn't like that i used BREAKING CHANGE:

@gr2m gr2m changed the title BREAKING CHANGE: drop support for Node 12 fix: drop support for Node 12 Jan 26, 2022
@gr2m
Copy link
Collaborator

gr2m commented Jan 26, 2022

seem like Semantic Pull Request linter didn't like that i used BREAKING CHANGE:

The BREAKING CHANGE: needs to go into the commit body, not the commit subject.

@gr2m gr2m enabled auto-merge (squash) January 26, 2022 20:33
@gr2m
Copy link
Collaborator

gr2m commented Jan 26, 2022

No idea why the "Semantic Pull Request" app is still complaining :( I'd ignore it

When you squash, make sure make the commit something like

drop support for Node 12

BREAKING CHANGE: drop support for Node 12

with the BREAKING CHANGE: in the commit body

@jimmywarting jimmywarting merged commit 8c1fe41 into node-fetch:beta Jan 27, 2022
@jimmywarting jimmywarting deleted the change-version branch January 27, 2022 00:27
@github-actions
Copy link

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants