Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent unsubscribe from leaking listeners (#1295) #1474

Merged
merged 1 commit into from May 7, 2022
Merged

fix: Prevent unsubscribe from leaking listeners (#1295) #1474

merged 1 commit into from May 7, 2022
+9 −7

Commits on Jan 23, 2022

  1. Fix leaking listeners (#1295) 

    Since 8eeeec1 it seems listeners have been leaking on keep-alive
sockets.

Apparently abort() has been deprecated since v17, using close() the
onSocketClose listener is properly removed, and by creating a new onData
function I'm able to remove the 'data' listener too.
    @felipec
    felipec committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    ff68404 View commit details
    Browse the repository at this point in the history