Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing fix for typescript ~= 4.4 #1448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

typing fix for typescript ~= 4.4 #1448

wants to merge 1 commit into from

Conversation

based64god
Copy link

Purpose

Fixes an issue where Response could not be properly cast from node-fetch flavor Response to typescript's native Response type.

Changes

Use ReadableStream<Uint8Array> instead of NodeJS.ReadableStream

Additional information

  • I updated ./docs/CHANGELOG.md with a link to this PR or Issue
  • I updated ./docs/v3-UPGRADE-GUIDE
  • I updated readme
  • I added unit test(s)
  • Fixes #000

@based64god
Copy link
Author

As an aside, this might affect other versions as well, but I've only been able to test this fix with 4.4.

@jimmywarting
Copy link
Collaborator

jimmywarting commented Jan 15, 2022 •
edited

Erm... the .body isn't a whatwg ReadableStream... yet.
We are planing on changing it to a whatwg stream in the v4 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@based64god @jimmywarting