New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: semantic-release #1270
ci: semantic-release #1270
Conversation
It sounds awesome, think i would like to incorporate it into my repos also |
Ping @bitinn |
I created a dedicated npm account that can only publish the node-fetch package. it has 2FA enabled. I have also generated a NPM_TOKEN and added it to the repository secret |
@gr2m what is left to do? |
I'll add a However, when merging |
480765c
to
c3ac7d1
Compare
I'm set on my side, I do not have permission to do the rest. Feel free to make me an admin and I'll take care of the rest. I think I used to have the access rights, but they might have gotten lost with the transition to @node-fetch? I'm okay either way, let me know if you have any questions. Once we are done here, I'll backport the setup to |
I gave u admin rights |
@jimmywarting can you do a final review? I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe want a 2nd opinion on this?
pinging @LinusU
"branches": [ | ||
"+([0-9]).x", | ||
"main", | ||
"next", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does next
need any special config, like beta
, or it is automatically picked up from the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's automatically picked up from the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
🎉 Merged 🎉 hope this makes more rapid releases now Looking forward to using this and hoping to learn a thing or two |
w00p :) Don't hesitate to ping me for any questions, and in case something is acting up
Yes, let's do that. I usually link to the latest version of the |
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Follow up to #1257 (comment)
This pull request adds semantic-release. Once merged, GitHub/npm releases will be automated based on the following commit message conventions:
fix: ...
orfix(scope name): ...
prefix in subject: bumps fix version, e.g.1.2.3
→1.2.4
feat: ...
orfeat(scope name): ...
prefix in subject: bumps feature version, e.g.1.2.3
→1.3.0
BREAKING CHANGE:
in body: bumps breaking version, e.g.1.2.3
→2.0.0
Only one version number is bumped at a time, the highest version change trumps the others.
Besides publishing a new version to npm, semantic-release also creates a git tag and release on GitHub, generates changelogs from the commit messages and puts them into the release notes, creates comments on pull requests included in the release as well as the issues they resolved to notify about the new release.
semantic-release
with the current configruation supports releases to the@next
channel and pre-relaeses using thenext
andbeta
branches. There are some gotchas here, but I'd say we get there when we get there.I've been the maintainer of
semantic-release
for many years now, and I use it on nearly all my npm modules, I couldn't imagine doing Open Source without it. Let me know if you have any questions.Todos
3.x
branch, it seems to be obsolete #12712.x
branch #1272NPM_TOKEN
secret to the repository. I recommend creating a dedicated npm account that can only publish thenode-fetch
package. The bot account can have 2FA enabled, npm has automation tokens now that will work with semantic-release.CONTRIBUTING.md
, but we don't have one yet :)v2.x
,beta
,next
branches.I would recommend
squash & merge
. Do not ask contributors to fix their commit messages, we can just squash them into a single commit when merging.semantic-pull-request
appsemantic-pull-request
withtitleOnly: true
.