Wrap blobs into a node stream #1092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit I also added a test for feature buffer.Blob and i also made a helper function to read blobs that don't have any stream function yet. |
|
there is three issues with buffer.Blob
|
jimmywarting
changed the title
tinovyatkin
approved these changes
Feb 27, 2021
|
guess we might as well turn this to v4's whatwg:stream instead |
2 tasks
|
picked up my old #924 PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (provide an overview)
Regarding what type of blob.stream it is (whether it's a node stream, whatwg stream or just a async iterator that yields uint8arrays)
always wrap the stream it returns in to a node stream.
Which issue (if any) does this pull request address?
closes #1091
Is there anything you'd like reviewers to know?
buffer.Blob()is soon becoming a thing...