Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 stable release #1257

Merged
merged 2 commits into from Aug 31, 2021
Merged

V3 stable release #1257

merged 2 commits into from Aug 31, 2021

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Aug 28, 2021

Purpose

Going out of beta and marking v3 as stable

Changes

package.json version + changelog only

Additional information

Have kind of forgot what the procedure is to release something on github/npm
is there some auto release to npm when a github tag is generated or something?



@jimmywarting jimmywarting added this to the Version 3.0.0 milestone Aug 28, 2021
@jimmywarting jimmywarting changed the title V3 stable V3 stable release Aug 28, 2021
@Richienb
Copy link
Member

Have kind of forgot what the procedure is to release something on github/npm

Since we aren't bundling anything anymore, np will come in handy.

@jimmywarting
Copy link
Collaborator Author

jimmywarting commented Aug 28, 2021

Since we aren't bundling anything anymore, np will come in handy.

np was quite large: https://npmgraph.js.org/?q=np
354 Modules!

Would kind of rather have some github workflow automations instead

It's easy to tag a new github version without having to make a PR like this one and having to wait for other members to review & accept it.

@gr2m
Copy link
Collaborator

gr2m commented Aug 28, 2021

I can setup semantic-release. I think I suggested it before? I’m a co maintainer of @semantic-release so I can take ownership of that part

@jimmywarting
Copy link
Collaborator Author

jimmywarting commented Aug 28, 2021

I can setup semantic-release. I think I suggested it before? I’m a co maintainer of @semantic-release so I can take ownership of that part

Think that would be grate to have! I say go for it

@gr2m gr2m assigned gr2m and unassigned gr2m Aug 29, 2021
@gr2m
Copy link
Collaborator

gr2m commented Aug 29, 2021

I can setup semantic-release. I think I suggested it before? I’m a co maintainer of @semantic-release so I can take ownership of that part

Think that would be grate to have! I say go for it

Unless there are any objections, we can go ahead and merge this PR, then I can do the semantic-release setup in its own PR

@node-fetch node-fetch deleted a comment from Richienb Aug 31, 2021
@jimmywarting jimmywarting merged commit 2603c67 into node-fetch:main Aug 31, 2021
@jimmywarting jimmywarting deleted the v3-stable branch August 31, 2021 15:54
@gr2m
Copy link
Collaborator

gr2m commented Aug 31, 2021

I can work on the semantic-release setup PR on Thursday.

@gr2m gr2m mentioned this pull request Sep 3, 2021
8 tasks
@Pencab

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3 Roadmap
5 participants