built-in typescript support #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperchupuDev
force-pushed
the
built-in-types
branch
from
4bed979
to
ddd5c7c
Compare
theblackman2
approved these changes
Feb 9, 2023
|
I'm currently working with typescript, and I think this is a good idea, no need to install another package for types support :) |
|
@merencia any chance you can look into this anytime soon? having integrated TS types would be really nice and it's been 7 months since the PR was opened |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, TypeScript users have to install a separate package (
@types/node-cron) to get type definitions. This PR adds built-in types copied from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node-cron/index.d.ts.I believe this is a good idea for two reasons: