Merge pull request #241 from muhammadtalhas/multi-range-fix

Fixes #240. Edge case when dealing with multiple ranges for one parameter of the cron input
node-cron · Mar 10, 2021 · 12d58ad · 12d58ad
2 parents 427483c + fbb333a
commit 12d58ad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/convert-expression/range-conversion.js b/src/convert-expression/range-conversion.js
@@ -15,7 +15,7 @@ module.exports = ( () => {
             numbers.push(i);
         }
 
-        return expression.replace(new RegExp(text, 'gi'), numbers.join());
+        return expression.replace(new RegExp(text, 'i'), numbers.join());
     }
 
     function convertRange(expression){

diff --git a/test/convert-expression/range-conversion-test.js b/test/convert-expression/range-conversion-test.js
@@ -15,4 +15,10 @@ describe('range-conversion.js', () => {
         const expression = conversion(expressions).join(' ');
         expect(expression).to.equal('0,1,2,3 0,1,2,3 8,9,10 1,2,3 1,2 0,1,2,3');
     });
+
+    it('should convert comma delimited ranges to numbers', () => {
+        var expressions = '0-2,10-23'.split(' ');
+        var expression = conversion(expressions).join(' ');
+        expect(expression).to.equal('0,1,2,10,11,12,13,14,15,16,17,18,19,20,21,22,23');
+    });
 });