Fix conversion of Uint8Array to object (#761) #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorenwest This PR seems consistent with some other special cases we handle and includes test coverage. I recommend merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in #761,
node-confighandlesTypedArrayvalues (includingUint8Array) incorrectly, wrapping them in proxy objects that are not accepted by anything that expects a realTypedArray(e.g.Buffer.from()).I hit this bug with
js-yaml4.x, which made a breaking change compared tojs-yaml3.x, returningUint8Arrayfor!!binaryvalues rather than returningBufferlike 3.x did.This PR:
makeImmutable()ignoreTypedArrayandDataViewvalues (leaving them mutable, as there's no way to make them immutable)cloneDeep()correctly cloneTypedArrayandDataViewvaluesjs-yamldev dependency to the latest version 4.1.0, which hits the bug innode-config