Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-746 - Loading config files order with APP_INSTANCE #747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgaestel
Copy link

@sgaestel sgaestel commented Nov 16, 2023

This will fix the loading order when having different file extensions and working with APP_INSTANCE as well.
Instead of doing a forEach on basenames and extensions, then adding the APP_INSTANCE, the filename using the APP_INSTANCE is defined before going through all extensions, so that it is loaded after all extensions without the APP_INSTANCE being defined.

Did a console.log (that I removed) for the allowedFiles object when running the added test to show the difference:
Before the fix:
image

After the fix:
image

@lorenwest
Copy link
Collaborator

This looks really good. I'm surprised it took this long to discover - probably because mixed file types with instances isn't very common.

Thank you for finding, fixing, and writing the test! I'll bring it in and so some local testing, then push a new release with this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants