refactor: 馃挕 convert prototype to class #728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃憤馃徏 Looks like this doesn't cause any new test failures. |
|
I'm in favor of merging this, but would like to get #704 resolved first. You are welcome to take a look if you'd like. |
|
This appears to conflict with your other PR. I'll merge it when the conflicts are resolved. |
# Conflicts: # lib/config.js
|
Hi sir! I've resolved all the conflicts! I believe it should be good to go now! 馃挭 馃槉 |
|
I would love to get util factored completely out, but it is stateful in a couple of places that make that tricky. this might be a step toward that eventuality, or at least it doesn鈥檛 seem to make things worse.. LGTM |
|
I think we could also start using nullish operators, but that would necessitate bumping to node 14 and trunk is still on 10.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I convert the prototype-based implementation to a class-based implementation! Please have a look!