Fixed property mutation. Throw an exception on such an attempt. Updat… #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed tests to capture this exception.
|
This looks great. I'm not as familiar with Proxy and Reflect as you are, so I can't give it a thorough review, but if it passes the tests and works on all versions tested by Travis it should be good. |
|
I'll give it a day or two for others to review, then merge. |
|
Sounds good - thank you! |
|
Apologies for the delayed merged. It's helpful to explicitly throw errors when mutation attempts are made. This may need a major version bump as a behavior change, though. |
1 task
|
@fgheorghe Could you check out the linked bug reports related to this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed tests to capture this exception.