Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @definitelytyped/dtslint from 0.0.163 to 0.2.13 #2594

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 26, 2024

Bumps @definitelytyped/dtslint from 0.0.163 to 0.2.13.

Release notes

Sourced from @​definitelytyped/dtslint's releases.

@​definitelytyped/dtslint@​0.2.13

Patch Changes

  • Updated dependencies [5e7da60]
    • @​definitelytyped/utils@​0.1.4
    • @​definitelytyped/header-parser@​0.2.5

@​definitelytyped/dtslint@​0.2.12

Patch Changes

  • e2aef2f: Pull expectedNpmVersionFailures from GitHub, like allowedPackageJsonDependencies
  • Updated dependencies [e2aef2f]
    • @​definitelytyped/utils@​0.1.3
    • @​definitelytyped/header-parser@​0.2.4

@​definitelytyped/dtslint@​0.2.11

Patch Changes

  • b9ca741: remove aws-lambda from expected npm version failures
  • b2f229a: Update arethetypeswrong

@​definitelytyped/dtslint@​0.2.10

Patch Changes

  • 7668808: Update @​arethetypeswrong/cli

@​definitelytyped/dtslint@​0.2.9

Patch Changes

  • 57bb3ea: Rework error collection
  • 57bb3ea: Error if tslint.json is present
  • a79806d: Update arethetypeswrong version

@​definitelytyped/dtslint@​0.2.8

Patch Changes

  • aa26880: Don’t crash when implementation package fails to extract

@​definitelytyped/dtslint@​0.2.7

Patch Changes

  • 31de5d3: Run arethetypeswrong from in-memory tarball data
  • 9da3fc7: Detect package names added/removed from attw.json as changed
  • Updated dependencies [31de5d3]
  • Updated dependencies [9da3fc7]
    • @​definitelytyped/utils@​0.1.2
    • @​definitelytyped/header-parser@​0.2.3

@​definitelytyped/dtslint@​0.2.6

Patch Changes

... (truncated)

Changelog

Sourced from @​definitelytyped/dtslint's changelog.

0.2.13

Patch Changes

  • Updated dependencies [5e7da60]
    • @​definitelytyped/utils@​0.1.4
    • @​definitelytyped/header-parser@​0.2.5

0.2.12

Patch Changes

  • e2aef2f: Pull expectedNpmVersionFailures from GitHub, like allowedPackageJsonDependencies
  • Updated dependencies [e2aef2f]
    • @​definitelytyped/utils@​0.1.3
    • @​definitelytyped/header-parser@​0.2.4

0.2.11

Patch Changes

  • b9ca741: remove aws-lambda from expected npm version failures
  • b2f229a: Update arethetypeswrong

0.2.10

Patch Changes

  • 7668808: Update @​arethetypeswrong/cli

0.2.9

Patch Changes

  • 57bb3ea: Rework error collection
  • 57bb3ea: Error if tslint.json is present
  • a79806d: Update arethetypeswrong version

0.2.8

Patch Changes

  • aa26880: Don’t crash when implementation package fails to extract

0.2.7

Patch Changes

  • 31de5d3: Run arethetypeswrong from in-memory tarball data
  • 9da3fc7: Detect package names added/removed from attw.json as changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 26, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/definitelytyped/dtslint-0.2.13 branch from b5a8ebf to d41ebcd Compare February 26, 2024 19:58
Bumps [@definitelytyped/dtslint](https://github.com/microsoft/DefinitelyTyped-tools/tree/HEAD/packages/dtslint) from 0.0.163 to 0.2.13.
- [Release notes](https://github.com/microsoft/DefinitelyTyped-tools/releases)
- [Changelog](https://github.com/microsoft/DefinitelyTyped-tools/blob/main/packages/dtslint/CHANGELOG.md)
- [Commits](https://github.com/microsoft/DefinitelyTyped-tools/commits/@definitelytyped/dtslint@0.2.13/packages/dtslint)

---
updated-dependencies:
- dependency-name: "@definitelytyped/dtslint"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/definitelytyped/dtslint-0.2.13 branch from d41ebcd to 8749008 Compare February 26, 2024 20:03
@gr2m
Copy link
Member

gr2m commented Feb 26, 2024

seems like the recommendation is to just use TSD instead: microsoft/DefinitelyTyped-tools#775

@mikicho
Copy link
Contributor

mikicho commented Feb 26, 2024

yeah.
IMO, a better approach would be using JSDoc and generate the types instead of writing by hand and test them.

@Uzlopak
Copy link
Member

Uzlopak commented Feb 26, 2024

is there a jsdoc to ts types code?

@mikicho
Copy link
Contributor

mikicho commented Feb 26, 2024

@Uzlopak TS supports JSDocs officially; most (>95%) of the use cases are fully covered. To generate types run tsc --emitDeclrationOnly

@gr2m
Copy link
Member

gr2m commented Feb 26, 2024

IMO, a better approach would be using JSDoc and generate the types instead of writing by hand and test them.

Fine with me if you both agree.

I do like hand crafted type files for public APIs. Doing it all through JSDocs makes things quite messy. Doing JS + JSDoc + handwritten .d.ts is my favorite approach to build libraries now. I'd write separate tests for code and types. Like in this library for example: https://github.com/gr2m/github-project

@Uzlopak
Copy link
Member

Uzlopak commented Feb 26, 2024

I am not convinced by using jsdoc for generating typescript definitions.
I am also usually doing JS + JSDoc + handwritten .d.ts, like we do in fastify etc..

@gr2m
Copy link
Member

gr2m commented Feb 26, 2024

I am also usually doing JS + JSDoc + handwritten .d.ts, like we do in fastify etc..

let's do that then? Shall we just replace dtslint with TSD tests then?

@Uzlopak
Copy link
Member

Uzlopak commented Feb 27, 2024

Yes. Replace dtslint with tsd.

@mikicho
Copy link
Contributor

mikicho commented Feb 27, 2024

👌

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 1, 2024

Superseded by #2600.

@dependabot dependabot bot closed this Mar 1, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/definitelytyped/dtslint-0.2.13 branch March 1, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants