Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve coverage of socket.js #2593

Merged
merged 2 commits into from Feb 26, 2024
Merged

chore: improve coverage of socket.js #2593

merged 2 commits into from Feb 26, 2024

Conversation

Uzlopak
Copy link
Member

@Uzlopak Uzlopak commented Feb 25, 2024

smoll test

@Uzlopak Uzlopak requested review from gr2m and mikicho February 25, 2024 03:27
@gr2m
Copy link
Member

gr2m commented Feb 25, 2024

The CI error feels like a cross-spawn error to me ... 🤔

mikicho
mikicho approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@mikicho mikicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@Uzlopak Uzlopak merged commit 652c689 into beta Feb 26, 2024
14 checks passed
@Uzlopak Uzlopak deleted the improve-coverage branch February 26, 2024 12:27
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 14.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikicho mikicho mikicho approved these changes

@gr2m gr2m Awaiting requested review from gr2m

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uzlopak @gr2m @mikicho