New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: native fetch mocking #2580
Conversation
I restructured few weeks ago the test folder. The folder test/got contains all tests which are got specific. So theoretically, you could copy the folder and name it fetch and rewrite the tests from using got to fetch. |
Outstanding!!
Agree!
Yes! I'll setup beta releasing. Feel free to drop any support/tests for any Node version below 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me, thank you for working on this ❤️ you can merge at will into the beta branch, it will do automated pre-releases that you can then install with nock@beta
. Just include this in the merge commit body (not subject):
BREAKING CHANGE: drop support for Node < 18
Even if you haven't implemented that yet, it's just so that the beta version starts at 14.0.0-beta.1 instead of 13.6.0-beta
@gr2m Thanks! It would also solve the coverage issues. Also, seems like we need to adjust the configuration in the settings: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🎉 This PR is included in version 14.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I think this is a great first step, @mikicho. Apologies for my limited availability over the past week, I've got buried in a few tasks. I will get back to our discussion on sockets and pending issues as soon as I can! Thank you! |
BREAKING CHANGE: drop support for Node < 18
Fetch support.
@gr2m WDYT?
CC @kettanaito