Support using AbortSignal to abort requests

[paulbrimicombe]

See #2478

Problem

• HTTP requests can now be aborted using an AbortSignal
• nock currently has no support for this

Solution

• Destroy the request when an abort signal enters the aborted state

[paulbrimicombe]

Any chance that this could be reviewed / merged please? It's causing us issues when testing code that uses AbortSignal for timeouts. If there are reasons why this can't be done, etc., please let me know so I can think about solutions.

[gr2m]

Sorry that the current nock version still supports Node 10 😞 We are working on support for the native fetch as our priority, we will probably bump the minimal node version to 18 as part of that

[paulbrimicombe]

Sorry that the current nock version still supports Node 10 😞 We are working on support for the native fetch as our priority, we will probably bump the minimal node version to 18 as part of that

Hi @gr2m , thanks so much for getting back to me! I'm pretty sure it's only the tests that don't run on earlier versions of Node but I quite understand if you want to hang fire on this until the native fetch stuff is complete.

[schrizsz]

Had to use this fork to test a request deduplication fn using abortController code in jest tests for FE 🙏 to merge. (node 18 + jest unit test)

[mikicho]

Maybe we can merge this for the beta instead.

[gr2m]

I changed head and updated the PR with latest changes from the beta branch

[bkendall]

(this looks awesome - came here looking to see why my timeouts weren't working on the beta branch, and this would do it!)

[mikicho]

@bkendall If you are referring to the fetch API, please see this URL: #2602.