fix(README): Update axios example #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added with nock#1711 but [has changed with axios v1](axios/axios#5277)
depoulo
commented
Apr 18, 2023
mastermatt
approved these changes
Apr 26, 2023
depoulo
commented
Apr 27, 2023
| @@ -1540,6 +1540,9 @@ import test from 'ava' // You can use any test framework. | |||
| // | |||
| // References: | |||
| // https://github.com/axios/axios/pull/5277 | |||
| // https://github.com/nock/nock/issues/699#issuecomment-272708264 | |||
There was a problem hiding this comment.
Well this no longer works, which is the whole point of my PR, same for the link right below.
There was a problem hiding this comment.
Sorry @depoulo, that was me messing up the rebase. I'll remove those two lines in another PR I have open for approval atm.
There was a problem hiding this comment.
no worries, and thanks for merging!
depoulo
commented
Apr 27, 2023
| @@ -1561,13 +1564,15 @@ test('can fetch test response', async t => { | |||
| For Nock + Axios + Jest to work, you'll have to also adapt your jest.config.js, like so: | |||
|
|
|||
| ```js | |||
| moduleNameMapper: { | |||
| const config = { | |||
|
🎉 This PR is included in version 13.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added with #1711 but has changed with axios v1