Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make nock.removeInterceptor ignore scope._persist and update scope.interceptors #2355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make nock.removeInterceptor ignore scope._persist and update scope.interceptors #2355

wants to merge 2 commits into from

Commits on Feb 17, 2024

  1. Allow explicitly removing interceptors from scopes with persist()

    @mbargiel
    mbargiel committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    48875f7 View commit details
    Browse the repository at this point in the history

  2. Change scope.remove to also remove interceptor from scope.interceptors 

    Note: for consistency between scope.interceptors and scope.keyedInterceptors,
interceptors are now only pushed to scope.interceptors when they are added,
not when they are created. That guarantees both collections are consistent.
    @mbargiel
    mbargiel committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    1e57041 View commit details
    Browse the repository at this point in the history