Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC - Consistent path comparison #2324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RFC - Consistent path comparison #2324

wants to merge 2 commits into from

Commits on Mar 28, 2022

  1. test(interceptor): add failing tests

    @mastermatt
    mastermatt committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    60cd1e8 View commit details
    Browse the repository at this point in the history

  2. feat(intercept): path matching only uses pathname 

    BREAKING CHANGE: The query/search portion of the path is now always excluding during path matching.

Previously, the pathname and search string  were included during path comparison by default, however, the search string was removed during the matching step if the `query` method had been called or a search string was provided as part of a string to the first argument of a "verb" method.
This change makes the experience consistent by making query/search matching exclusively opt-in.
    @mastermatt
    mastermatt committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2d8b155 View commit details
    Browse the repository at this point in the history