Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dep): migrate from lodash.set to lodash. #2306

Merged
merged 4 commits into from Jun 3, 2022
Merged

Commits on Feb 17, 2022

  1. fix(dep): migrate from lodash.set to lodash.

    Listing `lodash` as a prod dependency has a few advantages over the single func dep we were using.
    Primarily, when a security vulnerability is patched in LoDash, those changes don't get published to individual function libs anymore.
    The most recent example being the prototype pollution that was patched in 4.17.16.
    That particular vulnerability didn't effect Nock because of our usage, however, Nock does show up as having a vulnerability because of it which is a pain for consumers. It also creates a future problem where the next patch could affect Nock more directly.
    #2279
    
    It should be noted that LoDash itself discourages the use of these single function libs: https://lodash.com/per-method-packages
    
    This changes also removes the vendor-izing of two LoDash functions in favor of using the lib directly (`isPlainObject` and `mapValues`).
    mastermatt committed Feb 17, 2022
    Copy the full SHA
    31ed591 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Copy the full SHA
    01142d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Copy the full SHA
    214ccf5 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Copy the full SHA
    7f88390 View commit details
    Browse the repository at this point in the history