Clean scope #2282
Closed
Clean scope #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found an issue with my PR, doesn't work for persisted scopes |
|
@KristjanTammekivi Would you like to complete this PR? |
|
Well #2252 is still open, not sure if it will ever be finished. My implementation of this has the issue where it can't clear .persist()-ed mocks, and I don't have the energy to get familiar with this repo to find out why it happens and how to do it better. I have been using a private fork with this fix applied and other than that it seems to work. I'm leaving this PR open, maybe someone wants to continue the work. |
|
I see. Thanks! I'm closing this as part of an effort to clean stale issues/PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would make it easier to replace a mock (that's set up in a beforeEach for reusability) for one specific testcase