Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duplicate Headers #2264

Closed
wants to merge 6 commits into from
Closed

Fix Duplicate Headers #2264

wants to merge 6 commits into from

Conversation

MuckT
Copy link

@MuckT MuckT commented Dec 3, 2021

This is my first PR to nock please let me know if there are any additional steps needed.

@mastermatt
Copy link
Member

Hey thanks for the PR. It looks like this was work that was already done but never got merged in (then closed accidentally).
The previous thread with discussion on approach is in #1969 and the resulting PR is #1972
I'd prefer we move forward with 1972 instead of this PR as it maintains the desired behavior of still erroring on dup headers in Nock options.

@MuckT
Copy link
Author

MuckT commented Dec 3, 2021

Closing in favor of #1972.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to convert header keys to lower case due to field name conflict: content-type
2 participants