Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#2185): add test to ensure recorder works when response stream not put in flowing mode #2257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

att14
Copy link

@att14 att14 commented Nov 30, 2021

ref #2185

@gr2m
Copy link
Member

gr2m commented Dec 1, 2021

Tests look good, thank you! Did you experiment with fixing it and see if it breaks any other tests?

@att14
Copy link
Author

att14 commented Dec 1, 2021

I played around with it a bit, but it appears to be an issue with the order the events are triggered in instead of my original flowing mode cause. I wasn't able to get this test to pass, even while breaking other tests.

Perhaps reading the stream takes enough time or gives enough cycles to the event loop that the other events take place before play() is called. I'll keep poking at it in my free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants