🚧 Gregor's code review and refactor #2252
Commits on Dec 13, 2021
-
-
-
-
```js const got = require('got') const intercept = require('./modules/node-intercept') run() async function run() { const reset = intercept() console.log('Intercepted:') console.log(await got('https://example.com').text()) // logs "Hello, world!" console.log('\n\nNot Intercepted:') reset() console.log(await got('https://example.com').text()) // logs HTML from example.com } ``` -
-
-
-
-
-
-
fix: thow error if nocks
http.ClientRequest()override is called wi……thout arguments. Check if response callback is set before using
-
Revert "test: make existing test more resilient without changing its …
…logic" This reverts commit ec8fb81.
-
-
-
-
-
test: skipping tests checking that the original
http.{get,request}……methods are called in case a request is not intercepted
-
-
-
-
-
-
-
-
test: adapt error message when overwritten
new http.ClientRequest()…… is called without options
-
test: adapt test for internal
normalizeRequestOptions()method. We ……no longer use a `.proto` property
-
test: adapt test for internal
stringifyRequest()method. We no long……er use a `.proto` property
-
-
test:
nock.removeInterceptor()no longer acceptsprotooption. Ex……pects `protocol` instead BREAKING CHANGE: `nock.removeInterceptor()` no longer accepts `proto` option. The option is `protocol` now and must be set to either `http:` or `https:`. Before ```js nock.removeInterceptor({ proto: "https", hostname: "example.test", path: "/somepath", }); ``` After ```js nock.removeInterceptor({ protocol: "https:", hostname: "example.test", path: "/somepath", }); ``` -
-
-
Revert "test: remove usage of fake timers where it is not needed"
This reverts commit dbb2af6.
-
-
-
-
-
-
-
-
test: should be safe to call in the middle of a request
see breaking change about intercept logic location
-
-
-
-
-
-
Commits on Dec 19, 2021
-
-
-
-
-
-
-
-
-
-
fix: when bypassing the intercept and sending the real request instea…
…d, call `.write` and `.end` on next tick and emit custom `nock-data` and `nock-end` events to enable recording of the request body