Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add removeInterceptorByPredictor to make interceptor removal logics customizable #2141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pillsilly
Copy link

@pillsilly pillsilly commented Feb 9, 2021

Current approach requires to give the actual interceptor or the options used in preset mocks.
But in real world it's not always that easy to retrieve those info as input of removeIntercetor() (e.g cucumber style)

So here I opened up a new path to enable customizable removal logic for user, let them programmatically decide which interceptor to remove.

Dear mainteners please help to check this PR. thanks.

@mastermatt

@pillsilly
Copy link
Author

@mastermatt would you kindly help to check this one?

@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

@stale stale bot added the stale label Sep 6, 2021
@gr2m gr2m added the Recorder related to recording fixtures or Nock Back label Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Recorder related to recording fixtures or Nock Back stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants