Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parallel requests on same Interceptor are exposed correctly in reply functions #2056

Merged
merged 4 commits into from
Aug 11, 2020

Commits on Jul 23, 2020

  1. fix: Parallel requests on same Interceptor are exposed correctly in r…

    …eply functions.
    
    Fixes regression created in nock#2033.
    Reply functions get access to the current request via the Interceptor,
    which acts as the context during the function executions.
    The previous change, incorrectly moved the line where the request was attached
    to the Interceptor up in the flow and out of the same microtask that calls the
    reply functions. Causing requests in parallel to lose the reference to the correct request.
    mastermatt committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    f0d15e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2020

  1. Configuration menu
    Copy the full SHA
    73cf1cc View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Configuration menu
    Copy the full SHA
    db44d2d View commit details
    Browse the repository at this point in the history
  2. fixup: use Sinon in test

    mastermatt committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d42bae5 View commit details
    Browse the repository at this point in the history