Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase record_unmatched functionality (PR #1235) #2039

Closed
wants to merge 5 commits into from

Conversation

guerrerocarlos
Copy link

@guerrerocarlos guerrerocarlos commented Jul 6, 2020

Rebasing PR #1235 to current main branch (also related to #1115 and #2038).

For backward compatibility added a record_unmatched flag that can be set true to record only the unmatched requests.

TODO:

  • Add record_unmatched Unit Tests
  • Add record_unmatched to Documentation (Update Readme)

closes #1235

@gr2m
Copy link
Member

gr2m commented Jul 9, 2020

@mastermatt @paulmelnikow any thoughts?

@guerrerocarlos
Copy link
Author

Maybe we can merge this PR, and I will make the TODO into another PR.

@mastermatt
Copy link
Member

I've been dragging my heels on this a bit since I'm not that familiar with Back, but I don't think merging this in without tests or docs is the right way to go.

@gr2m
Copy link
Member

gr2m commented Jul 14, 2020

I don't think merging this in without tests or docs is the right way to go.

Yes, I agree, especially given that the current nock maintainers don't use that feature much.

@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

@stale stale bot added the stale label Oct 12, 2020
@stale stale bot closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants