Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): consolidate local http server creation #1950

Merged
merged 1 commit into from
Mar 16, 2020

Commits on Mar 14, 2020

  1. refactor(test): consolidate local http server creation

    Following the same pattern used to HTTPS local servers, added a utility
    that creates and listens for a HTTP server and ensures it gets closed
    after the test ends.
    
    There were some tests that weren't properly closing the server if the
    test failed, but mostly this refactor reduces boilerplate from tests.
    
    Not all tests that call `http.createServer` were updated. The ones
    not migrated to Mocha DSL or Chai were left alone since they're due
    for refactors anyway.
    mastermatt committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    8638e5b View commit details
    Browse the repository at this point in the history