Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert breaking changes from v11.9.0 #1905

Merged
merged 1 commit into from Feb 16, 2020
Merged

Revert breaking changes from v11.9.0 #1905

merged 1 commit into from Feb 16, 2020

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Feb 16, 2020

Follow up to https://github.com/nock/nock/issues/1896\#issuecomment-586734273

This PR reverts the changes from these commits

@gr2m gr2m changed the base branch from beta to master February 16, 2020 18:07
@gr2m
Copy link
Member Author

gr2m commented Feb 16, 2020

@paulmelnikow @mastermatt does that look good to you?

@gr2m gr2m mentioned this pull request Feb 16, 2020
@paulmelnikow
Copy link
Member

I'm sure this is on your mind, though just a reminder that this needs to be merged with "fix".

@gr2m
Copy link
Member Author

gr2m commented Feb 16, 2020

this needs to be merged with "fix".

The commit has the fix: prefix, so it's all good? Or am I missing something?

@paulmelnikow
Copy link
Member

Ah, yes, I see it. I was looking at the title.

@gr2m gr2m merged commit 062c10e into master Feb 16, 2020
@gr2m gr2m deleted the revert-v11.9.0 branch February 16, 2020 18:33
@github-actions
Copy link

🎉 This PR is included in version 11.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link
Member Author

gr2m commented Feb 16, 2020

I've deprecated 11.9.0 on npm

➜  nock git:(release-version-12) npm info nock@11.9.0

nock@11.9.0 | MIT | deps: 5 | versions: 364
HTTP server mocking and expectations library for Node.js
https://github.com/nock/nock#readme

DEPRECATED ⚠️  - nock@11.9.0 included accidental breaking changes. Please update to nock@11.9.1 or above

@github-actions
Copy link

🎉 This PR is included in version 11.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants