Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Scope accepts legacy Url not WHATWG #1879

Merged
merged 3 commits into from Feb 10, 2020
Merged

fix(types): Scope accepts legacy Url not WHATWG #1879

merged 3 commits into from Feb 10, 2020

Commits on Feb 9, 2020

  1. fix(types): Scope accepts legacy Url not WHATWG 

    Updates the types to properly reflect that a Scope can be created with
the output of `url.parse`. Previously, it denoted that it accepted a
`url.URL` instance. To clarify, tests were also added proving that one
works while the other throws an error.
    @mastermatt
    mastermatt committed Feb 9, 2020
    Copy the full SHA
    498dd3f View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Merge branch 'master' into url-as-scope-input

    @paulmelnikow
    paulmelnikow committed Feb 10, 2020
    Copy the full SHA
    e447924 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into url-as-scope-input

    @mastermatt
    mastermatt committed Feb 10, 2020
    Copy the full SHA
    c3a4289 View commit details
    Browse the repository at this point in the history