Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allowMocked when using a callback for the path #1877

Merged
merged 4 commits into from Feb 10, 2020
Merged

fix: allowMocked when using a callback for the path #1877

merged 4 commits into from Feb 10, 2020

Commits on Feb 8, 2020

  1. fix: allowMocked when using a callback for the path 

    When an Interceptor was created with a comparator for the path, the
`matchOrigin` function was comparing the string equivalent of the function
instead of evaluating it.

I'm not a fan of the fact that the function `matchOrigin` is comparing the
pathname, but that's a refactor for another day.

Fixes: nock#1867
    @mastermatt
    mastermatt committed Feb 8, 2020
    Copy the full SHA
    65d0e74 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Merge branch 'master' into 1867/fix-allowunmocked-verb-callback

    @paulmelnikow
    paulmelnikow committed Feb 10, 2020
    Copy the full SHA
    5a2c795 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 1867/fix-allowunmocked-verb-callback

    @mastermatt
    mastermatt committed Feb 10, 2020
    Copy the full SHA
    afad481 View commit details
    Browse the repository at this point in the history

  3. format

    @mastermatt
    mastermatt committed Feb 10, 2020
    Copy the full SHA
    cd24533 View commit details
    Browse the repository at this point in the history