fix: allowMocked when using a callback for the path #1874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
approved these changes
Feb 7, 2020
package-lock.json
Outdated
| @@ -5,29 +5,30 @@ | |||
| "requires": true, | |||
| "dependencies": { | |||
| "@babel/code-frame": { | |||
| "version": "7.5.5", | |||
| "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.5.5.tgz", | |||
| "integrity": "sha512-27d4lZoomVyo51VegxI20xZPuSHusqbQag/ztrBC7wegWoQ1nLREPVSKSW8byhTlzTKyNE4ifaTA6lCp7JjpFw==", | |||
There was a problem hiding this comment.
This seems unrelated. Can you reset it?
There was a problem hiding this comment.
On a fresh clone, I was unable to run npm install or npm ci because of issues with this lock file, specifically some semantic-release sub dep that removed a version from npmjs.com.
I'll remove this from this PR, but needs to addressed in general. @gr2m should we update semantic-release to ^17.0?
|
Apparently I forgot how to use git for minute. I had to recreate the PR #1877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Interceptor was created with a comparator for the path, the
matchOriginfunction was comparing the string equivalent of the functioninstead of evaluating it.
I'm not a fan of the fact that the function
matchOriginis comparing thepathname, but that's a refactor for another day.
Fixes: #1867